Use new dialog design for validation dialog #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jenkinsci/company-cloudbees-developers |
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 2, 2024
basil
added a commit
to basil/bom
that referenced
this pull request
Oct 2, 2024
|
@zbynek This results in 24 new ATH failures in jenkinsci/acceptance-test-harness#1753. Can you prepare an ATH PR that adapts to this change? |
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 2, 2024
|
My mistake: those failures were on the LTS line, where this plugin cannot be installed. On the weekly line, ATH is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dialog design to remove dependency on YUI and improve theme support (jenkinsci/dark-theme-plugin#142 ). Analogous to jenkinsci/credentials-plugin#500
Screenshot
Testing done
Checked that dialog displays OK and Test button validates the data. I don't have a proper LDAP server running so I wasn't able to get successful validation, just checked that the data being validated looks OK.
Submitter checklist