Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing obsolete ContainerExecDecorator.processes #512

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 18, 2019

The trick introduced in #239 was always fragile (was tied to implementation details of durable-task), and as of jenkinsci/durable-task-plugin#49 no longer works and is no longer needed, as can be seen by log messages such as

Created process inside pod: [mypod-…], container: [busybox] with pid:[-1]

@Vlatombe Vlatombe merged commit 08a8d75 into jenkinsci:master Jun 18, 2019
@jglick jglick deleted the ContainerExecDecorator.processes branch June 18, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants