Allow customization of NodeProvisioner.PlannedNode using extension point #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Vlatombe
commented
Mar 21, 2018
Vlatombe
commented
- New extension point PlannedNodeBuilderFactory to allow extensions to provide alternative PlannedNode implementations.
- Builder pattern for KubernetesSlave to stop the explosion of constructors
* New extension point PlannedNodeBuilderFactory to allow extensions to provide alternative PlannedNode implementations. * Builder pattern for KubernetesSlave to stop the explosion of constructors
carlossg
reviewed
Mar 21, 2018
|
|
||
| public ProvisioningCallback(@Nonnull KubernetesCloud cloud, @Nonnull PodTemplate t, @CheckForNull Label label) { | ||
| public ProvisioningCallback(@Nonnull KubernetesCloud cloud, @Nonnull PodTemplate t) { |
carlossg
changed the title
carlossg
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.