-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ask API server for a Pod
during deletion unnecessarily
#1304
Conversation
sh 'mvn -B -ntp -Dset.changelist -Dmaven.test.failure.ignore clean install' | ||
infra.prepareToPublishIncrementals() | ||
junit 'target/surefire-reports/*.xml' | ||
retry(count: 3, conditions: [kubernetesAgent(handleNonKubernetes: true), nonresumable()]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[offtopic] handleNonKubernetes: true
feels weird, shouldn't the condition be renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is to handle the scenario on ci.jenkins.io where we are requesting a label which currently is handled by the kubernetes
plugin but admins have left open the possibility of switching to some other cloud if performance merits it.
rebuilding |
Flake
would that cause Related: jenkinsci/workflow-durable-task-step-plugin#180 Prior to that
Maybe 15 seconds here is a bit too short considering the 10 seconds delay between retries ? https://github.com/jenkinsci/remoting/blob/952d22bc5673950f53a949b49fbe1427d99324d9/src/main/java/hudson/remoting/Engine.java#L688 |
Probably; trying to make routine tests run in a reasonable amount of time. FYI jenkinsci/workflow-durable-task-step-plugin#284 |
Not tested yet, but hoping this would avoid
Probably the actual deletion would fail later anyway, but why make two API calls when one suffices (assuming you have not actually configured
OnFailure
)?