fix findbugs

jenkinsci · Nov 17, 2017 · 029f027 · 029f027
1 parent 7e9ee3f
commit 029f027
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/...main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerLogStepExecution.java b/...main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerLogStepExecution.java
@@ -35,6 +35,7 @@ public class ContainerLogStepExecution extends SynchronousNonBlockingStepExecuti
     private static final long serialVersionUID = 5588861066775717487L;
     private static final transient Logger LOGGER = Logger.getLogger(ContainerLogStepExecution.class.getName());
 
+    @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "not needed on deserialization")
     private transient final ContainerLogStep step;
     private transient KubernetesClient client;
 

diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerStepExecution.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerStepExecution.java
@@ -26,6 +26,7 @@ public class ContainerStepExecution extends StepExecution {
 
     private static final transient Logger LOGGER = Logger.getLogger(ContainerStepExecution.class.getName());
 
+    @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "not needed on deserialization")
     private final transient ContainerStep step;
 
     private transient KubernetesClient client;

diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java
@@ -33,6 +33,7 @@ public class PodTemplateStepExecution extends AbstractStepExecutionImpl {
 
     private static final transient String NAME_FORMAT = "%s-%s";
 
+    @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "not needed on deserialization")
     private final transient PodTemplateStep step;
     private final String cloudName;
 

diff --git a/src/test/java/org/jvnet/hudson/test/RestartableJenkinsNonLocalhostRule.java b/src/test/java/org/jvnet/hudson/test/RestartableJenkinsNonLocalhostRule.java
@@ -24,17 +24,7 @@
 
 package org.jvnet.hudson.test;
 
-import groovy.lang.Closure;
-import org.junit.rules.MethodRule;
-import org.junit.rules.TemporaryFolder;
 import org.junit.runner.Description;
-import org.junit.runners.model.FrameworkMethod;
-import org.junit.runners.model.Statement;
-
-import java.io.File;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.concurrent.Callable;
 
 /**
  * @author Scott Hebert