Added labels and annotations to Helm Chart #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration option for a user to specify annotations and labels for Jenkins CR and pod.
tumevoiz
suggested changes
Sep 25, 2020
Comment on lines
+59
to
+65
| $ helm install <name> jenkins/jenkins-operator | ||
| ``` | ||
|
|
||
| To add custom labels and annotations, you can use `values.yaml` file or pass them into `helm install` command, e.g.: | ||
|
|
||
| ```bash | ||
| $ helm install <name> jenkins/jenkins-operator --set jenkins.labels.LabelKey=LabelValue,jenkins.annotations.AnnotationKey=AnnotationValue |
There was a problem hiding this comment.
helm install <name> jenkins/jenkins-operator --set jenkins.labels.LabelKey=LabelValue,jenkins.annotations.AnnotationKey=AnnotationValue -> helm install <name> jenkins/jenkins-operator.
Add separated section with info about values.yaml customization possibility.
There was a problem hiding this comment.
Since I'm already changing docs later (recommiting to fix_docs pull request) I guess I can add it then to not generate docs twice? We could do separate page about customizing with helm and leave a link there or add a 'helm section' in existing customization page.
tomaszsek
requested changes
Sep 25, 2020
Added configuration option for the user to specify annotations and labels for Jenkins pod via helm. Updated installation guide with information about this feature.
tumevoiz
approved these changes
Sep 29, 2020
tomaszsek
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration option for the user to specify annotations and labels for Jenkins CR and pod via helm. Updated installation guide with information about this feature.
#432