Change helm chart to helm 3 apiVersion #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chart is already in the format of a Helm 3 chart, however the `apiVersion` of the chart is set to `v1`, which is used for Helm 2 charts. Helm 3 charts should use `apiVersion: v2`. This makes tools such as ArgoCD mistake the chart for a Helm 2 chart, and therefore template the chart using the wrong helm version. In ArgoCDs case, that means that the CRDs aren't deployed. reference: https://helm.sh/docs/faq/#chartyaml-apiversion-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The chart is already in the format of a Helm 3 chart, however the
apiVersionof the chart is set tov1, which is used for Helm 2 charts. Helm 3 charts should useapiVersion: v2.This makes tools such as ArgoCD mistake the chart for a Helm 2 chart, and therefore template the chart using the wrong helm version. In ArgoCDs case, that means that the CRDs aren't deployed.
reference: https://helm.sh/docs/faq/#chartyaml-apiversion-bump
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.
Release Notes