Use Deployment instead of Pod (intermediate PR) #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waveywaves
force-pushed
the
refactor/deployment
branch
3 times, most recently
from
c67aab1 to
55bf615
Compare
|
/retest |
waveywaves
force-pushed
the
refactor/deployment
branch
2 times, most recently
from
095b3e9 to
e96993f
Compare
jkhelil
reviewed
May 13, 2020
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
waveywaves
force-pushed
the
refactor/deployment
branch
3 times, most recently
from
bfee8c3 to
4e52eb3
Compare
tomaszsek
requested changes
May 14, 2020
pkg/controller/jenkins/configuration/base/resources/deployment.go
Outdated
Show resolved
Hide resolved
…ns Controller Allows for using the annotation jenkins.io/use-deployment and setting the value to true makes the operator use a Deployment instead of Pod for serving Jenkins. This is part of a temporary feature and has to be committed to avoid bigger PRs.
waveywaves
force-pushed
the
refactor/deployment
branch
from
4e52eb3 to
b77592e
Compare
|
May I know when this will be updated. Any thoughts on Timing or ETA here ? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Part of refactor for #195
Allows for using the annotation
jenkins.io/use-deploymentand setting the value to
truemakes the operator use aDeployment instead of Pod for serving Jenkins.
base/resources/pod.gotobase/resources/deployment.gojenkins.io/use-deploymentannotation is set totrueIMPORTANT NOTE:
The dependency on annotation is only temporary and the logic from reconciling with the Pod will be moved completely in the upcoming PRs for refactoring.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.
Release Notes