Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm/templates/jenkins.yaml] {{ with.jenkins.notifications }} on wrong line. #344

Closed
snooyen opened this issue Apr 22, 2020 · 1 comment
Closed

[helm/templates/jenkins.yaml] {{ with.jenkins.notifications }} on wrong line. #344

snooyen opened this issue Apr 22, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@snooyen
Copy link

snooyen commented Apr 22, 2020

Line 51 should be moved to Line 57. This is causing issues when overriding service and slaveservice settings via Helm chart values.

kubernetes-operator/chart/jenkins-operator/templates/jenkins.yaml

Line 51 in e4b168d

{{- with .Values.jenkins.notifications }}

tomaszsek added a commit that referenced this issue Apr 22, 2020
@tomaszsek
#344 Fix operator notifications in Helm Chart
9715217
@tomaszsek
Copy link

Fixed in 0.1.3 Helm Chart

@tomaszsek tomaszsek added the bug Something isn't working label Apr 22, 2020
akram pushed a commit to akram/jenkins-operator that referenced this issue May 6, 2020
@tomaszsek @akram
jenkinsci#344 Fix operator notifications in Helm Chart
187e2e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snooyen @tomaszsek