-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CD #43
Enable CD #43
Conversation
@Vlatombe could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the full setup from https://www.jenkins.io/redirect/continuous-delivery-of-plugins
It should be OK now, if I didn't miss anything. Added: cd.yaml, updated maven.config and pom.xml |
Still missing the dependabot entry
|
Sorry for that, didn't notice, I got confused with https://github.com/jenkinsci/kubernetes-credentials-plugin/blob/master/.github/dependabot.yml#L3-L8 (it's for maven, but not github-actions) |
Added in 780b751 |
Need jenkins-infra/repository-permissions-updater#3875 merged first, and this repository updated with the corresponding secrets for deployment (which happens automatically some time after) |
Thanks a lot for the review, @Vlatombe |
PR in RPU was merged, I think we can merge this PR now |
@maxlaverse FYI, and can you check https://www.jenkins.io/doc/developer/publishing/releasing-cd/#troubleshooting ? I don't have administrative right on this repo (only |
hi @Vlatombe ! I read the troubleshooting page. What do I need to troubleshoot ? It's meant for artifact upload errors, that would likely fail because of missing secrets, but those would be set automatically on this repository ? |
It's only to doublecheck that the CD setup happened properly and that the expected secrets are set in the repository. Otherwise we can just blindly merge and see whether the deployment happens as expected. |
Looks like the environment variables are here: GitHub actions are disabled however. Does it need more permission than that ? (couldn't see it on https://www.jenkins.io/doc/developer/publishing/releasing-cd/) |
I'm merging, then. |
@maxlaverse I think you'll have to tick the last option and add jenkins-infra/github-reusable-workflows to the selected non-jenkinsci actions as currently the GHA is failing:
|
I fixed the permissions issue @lemeurherve . Build is running: |
It seems so yes, no idea how to resolve this though, sorry. |
Testing done
Submitter checklist