Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73946] Remove inline event handlers in History/index.jelly #658

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin commented Oct 17, 2024

https://issues.jenkins.io/browse/JENKINS-73946

Testing done

Going to the history page and changing the values in the dropdowns is enough to trigger the affected code.

https://www.loom.com/share/37c4c276c3a14d2bab38168eb40f7af1?sid=310bc533-b971-4969-9a53-2098f7b3cffc

https://www.loom.com/share/170fb279203a4b38add532a1584cc87e?sid=45a8a87a-e919-4357-a836-0d87bf5dc1d9

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner October 17, 2024 10:53
yaroslavafenkin added a commit to yaroslavafenkin/acceptance-test-harness that referenced this pull request Oct 17, 2024
yaroslavafenkin added a commit to yaroslavafenkin/bom that referenced this pull request Oct 17, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application/json script tag was only acting as a data holder for the script and was not even triggering a violation

Why not keep it as-is, then, to minimize code change (i.e., risk) and the size of the diff (i.e. for reviewability)?

@yaroslavafenkin
Copy link
Contributor Author

The application/json script tag was only acting as a data holder for the script and was not even triggering a violation

Why not keep it as-is, then, to minimize code change (i.e., risk) and the size of the diff (i.e. for reviewability)?

I thought it wasn't even a valid thing to do, but I've looked it up and there seems to be nothing wrong with it. I'll revert that part.

@basil basil added the internal label Oct 17, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice and simple.

@basil basil changed the title [JENKINS-73946] Remove inline event handlers in History/index.jelly [JENKINS-73946] Remove inline event handlers in History/index.jelly Oct 17, 2024
@basil basil merged commit dd5b264 into jenkinsci:master Oct 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants