-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-69656] Un-inlining AbstractTestResultAction/summary.jelly for CSP compliance #444
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
src/main/resources/hudson/tasks/test/AbstractTestResultAction/show-failures.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/** | ||
* Displays all the tests failures, and hides the link allowing to display them from UI. | ||
*/ | ||
function showFailures() { | ||
// Displaying all the hidden elements from the page (those are the failed tests) | ||
let hiddenElements = document.getElementsByClassName("hidden"); | ||
|
||
// DEV MEMO: | ||
// hiddenElements is not an array but an HTMLCollection. | ||
// To allow using forEach, we need an array, so I'm using the spread operator below to get that. | ||
[...hiddenElements].forEach(element => { element.style.display = ""; }); | ||
|
||
// Now hiding the link from UI allowing to show all failed tests | ||
let showFailuresLink = document.getElementById("showLink"); | ||
showFailuresLink.style.display = "none"; | ||
} | ||
|
||
// Adding an onclick listener to the link in UI allowing to display all failed tests | ||
// DEV MEMO: | ||
// We are doing it after DOM content is loaded as a good practice to ensure we are not slowing down | ||
// the page rendering. In that particular situation the addition of the onclick handler shouldn't | ||
// really impact the page performances, but rather stick with good practices. | ||
|
||
document.addEventListener('DOMContentLoaded', (event) => { | ||
|
||
// Retrieving the link from UI allowing to show all failed tests | ||
// Note: we are retrieving the link by its ID to match how it was already done | ||
// in the showFailures method above. | ||
const showFailuresLink = document.getElementById("showLink"); | ||
|
||
showFailuresLink.onclick = (_) => showFailures(); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
The Jira issue (JENKINS-69656) mentioned:
But the original piece of code was actually using
document.getElementById("showLink")
to identify the link, so I considered it safe to rely on the very same identification for adding theonclick
handler.If you feel like it's not good enough, I'm happy to change it, but the current proposal matches the original behavior of the source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a matter of luck, but we have several occurrences of
showLink
being used as id: https://github.com/search?l=XML&q=org%3Ajenkinsci+showLink&type=CodeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to change it in that PR with something unique (both in the
onclick
and in theshowFailures
function)?Or should I create another issue to fix it? (or ignore it?)