Add missing @OverRide annotation (#313)

jenkinsci · Oct 31, 2021 · 3cc961f · 3cc961f
1 parent b89c952
commit 3cc961f
Show file tree

Hide file tree

Showing 19 changed files with 89 additions and 3 deletions.
diff --git a/src/main/java/hudson/tasks/junit/CaseResult.java b/src/main/java/hudson/tasks/junit/CaseResult.java
@@ -254,6 +254,7 @@ private static int halfMaxSize(Collection<CaseResult> results) {
         return HALF_MAX_SIZE;
     }
 
+    @Override
     public ClassResult getParent() {
         return classResult;
     }
@@ -304,6 +305,7 @@ public String getTransformedTestName() {
         return TestNameTransformer.getTransformedName(getName());
     }
 
+    @Override
     public String getDisplayName() {
         return getNameWithEnclosingBlocks(getTransformedTestName());
     }
@@ -349,6 +351,7 @@ public String getTitle() {
      * Gets the duration of the test, in seconds
      */
     @Exported(visibility=9)
+    @Override
     public float getDuration() {
         return duration;
     }
@@ -409,6 +412,7 @@ public String getFullName() {
     /**
      * @since 1.515
      */
+    @Override
     public String getFullDisplayName() {
         return getNameWithEnclosingBlocks(getTransformedFullDisplayName());
     }
@@ -436,6 +440,7 @@ public int getPassCount() {
      * when this test started failing.
      */
     @Exported(visibility=9)
+    @Override
     public int getFailedSince() {
         // If we haven't calculated failedSince yet, and we should,
         // do it now.
@@ -457,6 +462,7 @@ private void recomputeFailedSinceIfNeeded() {
         }
     }
 
+    @Override
     public Run<?,?> getFailedSinceRun() {
         JunitTestResultStorage storage = JunitTestResultStorage.find();
         if (!(storage instanceof FileJunitTestResultStorage)) {
@@ -500,6 +506,7 @@ else if (getRun() != null) {
      * @since 1.294
      */
     @Exported
+    @Override
     public String getStdout() {
         if(stdout!=null)    return stdout;
         SuiteResult sr = getSuiteResult();
@@ -514,6 +521,7 @@ public String getStdout() {
      * @since 1.294
      */
     @Exported
+    @Override
     public String getStderr() {
         if(stderr!=null)    return stderr;
         SuiteResult sr = getSuiteResult();
@@ -582,6 +590,7 @@ private Collection<? extends hudson.tasks.test.TestResult> singletonListOfThisOr
      * If there was an error or a failure, this is the stack trace, or otherwise null.
      */
     @Exported
+    @Override
     public String getErrorStackTrace() {
         return errorStackTrace;
     }
@@ -590,13 +599,15 @@ public String getErrorStackTrace() {
      * If there was an error or a failure, this is the text from the message.
      */
     @Exported
+    @Override
     public String getErrorDetails() {
         return errorDetails;
     }
 
     /**
      * @return true if the test was not skipped and did not fail, false otherwise.
      */
+    @Override
     public boolean isPassed() {
         return !skipped && errorDetails == null && errorStackTrace==null;
     }
@@ -688,6 +699,7 @@ public void freeze(SuiteResult parent) {
         recomputeFailedSinceIfNeeded();
     }
 
+    @Override
     public int compareTo(CaseResult that) {
         if (this == that) {
             return 0;

diff --git a/src/main/java/hudson/tasks/junit/ClassResult.java b/src/main/java/hudson/tasks/junit/ClassResult.java
@@ -62,6 +62,7 @@ public ClassResult(PackageResult parent, String className) {
         return parent==null ? null: parent.getRun();
     }
 
+    @Override
     public PackageResult getParent() {
         return parent;
     }
@@ -91,6 +92,7 @@ public hudson.tasks.test.TestResult findCorrespondingResult(String id) {
         return getCaseResult(caseName);
     }
 
+    @Override
     public String getTitle() {
         return Messages.ClassResult_getTitle(getDisplayName());
     }
@@ -101,6 +103,7 @@ public String getChildTitle() {
     }
 
     @Exported(visibility=999)
+    @Override
     public String getName() {
         int idx = className.lastIndexOf('.');
         if(idx<0)       return className;
@@ -134,30 +137,36 @@ public Object getDynamic(String name, StaplerRequest req, StaplerResponse rsp) {
 
 
     @Exported(name="child")
+    @Override
     public List<CaseResult> getChildren() {
         return cases;
     }
 
+    @Override
     public boolean hasChildren() {
         return (cases != null) && (cases.size() > 0);
     }
 
     // TODO: wait for stapler 1.60     @Exported
+    @Override
     public float getDuration() {
         return duration; 
     }
 
     @Exported
+    @Override
     public int getPassCount() {
         return passCount;
     }
 
     @Exported
+    @Override
     public int getFailCount() {
         return failCount;
     }
 
     @Exported
+    @Override
     public int getSkipCount() {
         return skipCount;
     }
@@ -197,6 +206,7 @@ public String getClassName() {
     	return className;
     }
 
+    @Override
     public int compareTo(ClassResult that) {
         if (this.equals(that)) {
             return 0;
@@ -223,6 +233,7 @@ public int hashCode() {
         return System.identityHashCode(this);
     }
 
+    @Override
     public String getDisplayName() {
         return TestNameTransformer.getTransformedName(getName());
     }
@@ -235,6 +246,7 @@ public String getFullName() {
     	return getParent().getName() + "." + className;
     }
 
+    @Override
     public String getFullDisplayName() {
     	return getParent().getDisplayName() + "." + TestNameTransformer.getTransformedName(className);
     }

diff --git a/src/main/java/hudson/tasks/junit/JUnitParser.java b/src/main/java/hudson/tasks/junit/JUnitParser.java
@@ -134,6 +134,7 @@ private ParseResultCallable(String testResults, Run<?,?> build,
             this.listener = listener;
         }
 
+        @Override
         public T invoke(File ws, VirtualChannel channel) throws IOException {
             final long nowSlave = System.currentTimeMillis();
 

diff --git a/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java b/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
@@ -328,14 +328,17 @@ protected TestResult parseResult(DirectoryScanner ds, long buildTime)
         return new TestResult(buildTime, ds);
     }
 
+    @Override
     public BuildStepMonitor getRequiredMonitorService() {
         return BuildStepMonitor.NONE;
     }
 
+    @Override
     public String getTestResults() {
         return testResults;
     }
 
+    @Override
     public double getHealthScaleFactor() {
         return healthScaleFactor == null ? 1.0 : healthScaleFactor;
     }
@@ -349,7 +352,9 @@ public double getHealthScaleFactor() {
         this.healthScaleFactor = Math.max(0.0, healthScaleFactor);
     }
 
-    public @Nonnull List<TestDataPublisher> getTestDataPublishers() {
+    @Nonnull
+    @Override
+    public List<TestDataPublisher> getTestDataPublishers() {
         return testDataPublishers == null ? Collections.emptyList() : testDataPublishers;
     }
 
@@ -366,6 +371,7 @@ public double getHealthScaleFactor() {
     /**
      * @return the keepLongStdio.
      */
+    @Override
     public boolean isKeepLongStdio() {
         return keepLongStdio;
     }
@@ -383,6 +389,7 @@ public boolean isKeepLongStdio() {
      *
      * @return the allowEmptyResults
      */
+    @Override
     public boolean isAllowEmptyResults() {
         return allowEmptyResults;
     }
@@ -429,6 +436,7 @@ public void setSkipMarkingBuildUnstable(boolean skipMarkingBuildUnstable) {
 
     @Extension
     public static class DescriptorImpl extends BuildStepDescriptor<Publisher> {
+        @Override
         public String getDisplayName() {
             return Messages.JUnitResultArchiver_DisplayName();
         }
@@ -450,6 +458,7 @@ public FormValidation doCheckTestResults(
             return FilePath.validateFileMask(project.getSomeWorkspace(), value);
         }
 
+        @Override
         public boolean isApplicable(Class<? extends AbstractProject> jobType) {
             return true;
         }

diff --git a/src/main/java/hudson/tasks/junit/PackageResult.java b/src/main/java/hudson/tasks/junit/PackageResult.java
@@ -60,11 +60,13 @@ public Run<?,?> getRun() {
         return parent == null ? null : parent.getRun();
     }
 
+    @Override
     public hudson.tasks.junit.TestResult getParent() {
     	return parent;
     }
 
     @Exported(visibility=999)
+    @Override
     public String getName() {
         return packageName;
     }
@@ -158,6 +160,7 @@ public ClassResult getClassResult(String name) {
 	}
 
     @Exported(name="child")
+    @Override
     public Collection<ClassResult> getChildren() {
         return classes.values();
     }
@@ -175,6 +178,7 @@ public boolean hasChildren() {
      * Returns a list of the failed cases, in no particular
      * sort order
      */
+    @Override
     public List<CaseResult> getFailedTests() {
         TestResultImpl pluggableStorage = parent.getPluggableStorage();
         if (pluggableStorage != null) {
@@ -314,6 +318,7 @@ void freeze() {
         }
     }
 
+    @Override
     public int compareTo(PackageResult that) {
         if (this.equals(that)) {
             return 0;
@@ -340,6 +345,7 @@ public int hashCode() {
         return System.identityHashCode(this);
     }
 
+    @Override
     public String getDisplayName() {
         return TestNameTransformer.getTransformedName(packageName);
     }

diff --git a/src/main/java/hudson/tasks/junit/TestObject.java b/src/main/java/hudson/tasks/junit/TestObject.java
@@ -155,6 +155,7 @@ public TestObject getResultInRun(Run<?,?> run) {
 	 */
 	public abstract String getSafeName();
 
+    @Override
     public abstract String getSearchUrl();
 
     /**

diff --git a/src/main/java/hudson/tasks/junit/TestResult.java b/src/main/java/hudson/tasks/junit/TestResult.java
@@ -161,6 +161,7 @@ public TestResultImpl getPluggableStorage() {
         return impl;
     }
 
+    @Override
     public TestObject getParent() {
     	return parent;
     }
@@ -394,6 +395,7 @@ public void parse(File reportFile, PipelineTestDetails pipelineTestDetails) thro
         }
     }
 
+    @Override
     public String getDisplayName() {
         return Messages.TestResult_getDisplayName();
     }

diff --git a/src/main/java/hudson/tasks/junit/TestResultAction.java b/src/main/java/hudson/tasks/junit/TestResultAction.java
@@ -239,6 +239,7 @@ private TestResult load() {
         return r;
     }
 
+    @Override
     public Object getTarget() {
         return getResult();
     }
@@ -313,6 +314,7 @@ public static abstract class Data {
     	public abstract List<? extends TestAction> getTestAction(hudson.tasks.junit.TestObject testObject);
     }
 
+    @Override
     public Object readResolve() {
         super.readResolve(); // let it do the post-deserialization work
     	if (testData == null) {

diff --git a/src/main/java/hudson/tasks/junit/XMLEntityResolver.java b/src/main/java/hudson/tasks/junit/XMLEntityResolver.java
@@ -53,6 +53,7 @@ public class XMLEntityResolver implements EntityResolver {
     /**
      * Intercepts the lookup of publicId, systemId
      */
+    @Override
     public InputSource resolveEntity(String publicId, String systemId) throws SAXException, IOException {
         if (systemId != null) {
             if (LOGGER.isLoggable(Level.FINE)) {

diff --git a/src/main/java/hudson/tasks/junit/pipeline/JUnitResultsStep.java b/src/main/java/hudson/tasks/junit/pipeline/JUnitResultsStep.java
@@ -65,10 +65,12 @@ public JUnitResultsStep(String testResults) {
         this.testResults = testResults;
     }
 
+    @Override
     public String getTestResults() {
         return testResults;
     }
 
+    @Override
     public double getHealthScaleFactor() {
         return healthScaleFactor == null ? 1.0 : healthScaleFactor;
     }
@@ -83,8 +85,9 @@ public final void setHealthScaleFactor(double healthScaleFactor) {
         this.healthScaleFactor = Math.max(0.0, healthScaleFactor);
     }
 
-    public @Nonnull
-    List<TestDataPublisher> getTestDataPublishers() {
+    @Nonnull
+    @Override
+    public List<TestDataPublisher> getTestDataPublishers() {
         return testDataPublishers == null ? Collections.emptyList() : testDataPublishers;
     }
 
@@ -101,6 +104,7 @@ List<TestDataPublisher> getTestDataPublishers() {
     /**
      * @return the keepLongStdio.
      */
+    @Override
     public boolean isKeepLongStdio() {
         return keepLongStdio;
     }
@@ -118,6 +122,7 @@ public boolean isKeepLongStdio() {
      *
      * @return the allowEmptyResults
      */
+    @Override
     public boolean isAllowEmptyResults() {
         return allowEmptyResults;
     }