Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nth build failure for Email Extension plugin #1297

Conversation

cml37
Copy link
Contributor

@cml37 cml37 commented Mar 27, 2023

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cml37 cml37 requested a review from a team as a code owner March 27, 2023 18:40
@cml37
Copy link
Contributor Author

cml37 commented Mar 27, 2023

@cml37 cml37 requested a review from basil March 29, 2023 17:51
@cml37
Copy link
Contributor Author

cml37 commented Apr 9, 2023

@basil ping!

@cml37
Copy link
Contributor Author

cml37 commented Apr 25, 2023

@basil are you good with the changes?

@basil
Copy link
Member

basil commented Apr 25, 2023

This looks good at a high level. I will try to find a bit of time to test this out locally.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 0bb338e into jenkinsci:master Jun 2, 2023
@basil basil changed the title Add support for Nth build failure on the extended email trigger plugin Add support for Nth build failure for Email Extension plugin Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants