Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions based on changes made in matrix auth plugin 3.0 #1249

Closed
wants to merge 1 commit into from

Conversation

joshiparth1000
Copy link

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dsrink
Copy link

dsrink commented Jul 25, 2022

@joshiparth1000 This looks interesting, I would need exactly that change. Did you see the build errors in testing, would you be able to handle them?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are (trivial) CodeNarc violations causing the build to fail.

Why is this PR not in draft state when FolderSpec, JobAuthorizationContextSpec, and JobSpec are consistently failing?

What would happen if someone attempted to use Job DSL with the changes in this PR and Matrix Authorization Strategy 2.6.11?

@jstraw
Copy link

jstraw commented Mar 1, 2024

it seems like this change is now either required, or about to be for configuring a Jenkins without getting ambiguous permissions warnings.

@mickael-ange
Copy link

mickael-ange commented Mar 18, 2024

Hi

I'm not able to configure my job with new dis-ambiguous authorization format introduce in matrix auth plugin 3+.

job("dev/devops-ansible-rolling-update-adminsite") {
  disabled false
  authorization {
    permission("GROUP:hudson.model.Item.Build:dev-adminsite-deployer-only")
    permission("GROUP:hudson.model.Item.Cancel:dev-adminsite-deployer-only")
    permission("GROUP:hudson.model.Item.Read:dev-adminsite-deployer-only")
  }
  using "dev/devops-ansible-template"

I got the following error when I'm trying to process the new auth perms with Job DSL plugin.

ERROR: (unknown source) permission must be one of com.cloudbees.plugins.credentials.CredentialsProvider.Create,com.cloudbees.plugins.credentials.CredentialsProvider.Delete,com.cloudbees.plugins.credentials.CredentialsProvider.ManageDomains,com.cloudbees.plugins.credentials.CredentialsProvider.Update,com.cloudbees.plugins.credentials.CredentialsProvider.View,hudson.model.Item.Build,hudson.model.Item.Cancel,hudson.model.Item.Configure,hudson.model.Item.Delete,hudson.model.Item.Discover,hudson.model.Item.ExtendedRead,hudson.model.Item.Move,hudson.model.Item.Read,hudson.model.Item.Workspace,hudson.model.Run.Delete,hudson.model.Run.Replay,hudson.model.Run.Update,hudson.scm.SCM.Tag

I suppose this PR was aiming to fix this configuration change.

Any chance to resume the progress on this PR?

Thanks

@eva-mueller-coremedia
Copy link
Contributor

This is continued in #1415

@basil basil closed this in #1415 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants