-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hetero-list YUI button and menu with new style button and tippy.js menu #8340
Conversation
use new button style replace the YUI menu with a tippy menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK security wise
done
The Width changes with applied filters, but this was also the case before. Seems it is not possible with pure CSS to prevent this.
My intention was as there are no icons involved and the number of entries easily get over 20 (with flexible publish and any step plugins, I have here 23 entries in the menu) so I wanted it to be more compact. I increased the min-height now to 30px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, love it
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
… and tippy.js menu" (#8412) Revert "Replace hetero-list YUI button and menu with new style button and tippy.js menu (#8340)" This broke: - org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScriptTest - hudson.plugins.textfinder.TextFinderPublisherFreestyleTest#createTextFinderViaWebClient This reverts commit c1a6c6c.
This broke Reverted in #8412 Try again in the next weekly after ensuring that you are not breaking PCT |
If you're this strict about changes causing PCT regressions, while making it the submitters' responsibility, this needs to be documented in https://github.com/jenkinsci/jenkins/blob/master/CONTRIBUTING.md and https://github.com/jenkinsci/jenkins/blob/master/.github/PULL_REQUEST_TEMPLATE.md. |
…py.js menu (jenkinsci#8340) * refresh hetero-list UI use new button style replace the YUI menu with a tippy menu * fix lint errors * avoid blanks * prettier * keep button in div * fix test * fix test jenkinsci#2 * convert inputs to buttons for plugins * prettier * remove unnecessary style definition * remove adjunct * adjust filter --------- Co-authored-by: Tim Jacomb <[email protected]>
… and tippy.js menu" (jenkinsci#8412) Revert "Replace hetero-list YUI button and menu with new style button and tippy.js menu (jenkinsci#8340)" This broke: - org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScriptTest - hudson.plugins.textfinder.TextFinderPublisherFreestyleTest#createTextFinderViaWebClient This reverts commit c1a6c6c.
use new button style
replace the YUI menu with a tippy menu
Following plugins use the hetero-list-container and input button at some places without using the hetero-list.jelly. The input button is replaced by a jenkins button in javascript.
Some Notes
Before:
After:
Testing done
Freestyle jobs
Pipeline jpbs
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist