-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use major version of GitHub Actions #6428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for less noise.
uses: actions/upload-release-asset@v1.0.2 | ||
uses: actions/upload-release-asset@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are particular reason why core uses such an ancient version? The repository providing it is EOL since early 2021, therefore pinning this specific version has bar no effect on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository providing it is EOL since early 2021, therefore pinning this specific version has bar no effect on it.
And therefore no risk of regression! 😄
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great for me. Hopefully the dependabot issue will be fixed so that major version upgrades will be proposed when they happen. Until the bug is fixed, we can rely on a few of the plugin repositories that will likely continue using the fully specified version number. They can be the "canary" to alert a few people when a new major version is released and dependabot doesn't notify us.
See jenkinsci/file-parameters-plugin#90 (comment) - even though this PR subjects us to dependabot/dependabot-core#4834 I think it is still preferable to the status quo, wherein we get lots of noise like #6426.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).