Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67496] Drag & drop is messed up, drag placeholders always have tiny size #6184

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[JENKINS-67496] Drag & drop is messed up, drag placeholders always have tiny size #6184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions war/src/main/js/sortable-drag-drop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ function registerSortableDragDrop(e) {
forceFallback: true, // Do not use html5 drag & drop behaviour because it does not work with autoscroll
scroll: true,
bubbleScroll: true,
onChoose: function (event) {
const draggableDiv = event.item;
const height = draggableDiv.clientHeight;
draggableDiv.style.height = `${height}px`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We claim to still support IE 11 per https://www.jenkins.io/doc/administration/requirements/web-browsers/. If this is https://caniuse.com/template-literals, then this won't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic but is there a date in mind for when IE11 support will be dropped?

Copy link
Member

@daniel-beck daniel-beck Jan 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. Something for the UX sig I guess? Personally I don't care much either way but as long as we claim to support it, we should.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added to the agenda of the next meeting on Wednesday https://docs.google.com/document/d/1QttPwdimNP_120JukigKsRuBvMr34KZhVfsbgq1HFLM/edit#heading=h.5w6rztvl5s02

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and mailing list: https://groups.google.com/g/jenkinsci-dev/c/piANoeohdik/m/PewPuvLSAAAJ

},
onUnchoose: function (event) {
event.item.style.removeProperty('height');
}
});
}

Expand Down