[JENKINS-33596] Delete more of `UDPBroadcastThread` & `DNSMultiCast` #5720

jglick · 2021-09-10T15:46:43Z

Follows up #4460. See JENKINS-33596. These classes have been stubs for over a year and a half; it is just confusing to leave them in the source tree.

Proposed changelog entries

Removing long-unused class UDPBroadcastThread, and deleting more of DNSMultiCast.

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least 2 approvals for the pull request and no outstanding requests for change
Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
Changelog entries in the PR title and/or Proposed changelog entries are correct
Proper changelog labels are set so that the changelog can be generated automatically
If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

…kinsci/jenkins-test-harness/releases/tag/1626.v46b0925e70db

jglick · 2021-09-10T19:55:39Z

Note that linked PRs mean that you will need to update tools to work with the new jenkins.version; you should be able to update tools anyway, though if you have a very old jenkins.version (< 2.220) you may see some delays and/or warnings.

jglick · 2021-09-10T19:57:16Z

Hmm, it occurs to me this could cause problems for people running PCT across a lot of plugins with older POMs. Maybe I need to keep just DNSMultiCast.disabled around to avoid linkage errors.

…moveMulticast-redux

…isabled = true`

jeffret-b

I'm in favor of using these old things, but I do know from experience there can be some odd dependencies on the existence of some of these pieces. While I'd like to get rid of it all, a more cautious excision as this has evolved into is more prudent.

jglick · 2021-09-13T13:31:46Z

a more cautious excision as this has evolved into is more prudent

Not sure I follow what you are saying. You approved this PR; do you have reservations?

jeffret-b · 2021-09-13T13:35:34Z

No reservations. And I think it's safer to leave a little bit of it behind like you ended up doing.

jglick · 2021-09-13T13:39:39Z

To be clear, we cannot safely delete DNSMultiCast now; we could only delete it after any plugin which you might wish to run PCT against has updated to a new POM.

timja · 2021-09-13T13:44:15Z

test/pom.xml

@@ -81,7 +81,7 @@ THE SOFTWARE.
    <dependency>
      <groupId>${project.groupId}</groupId>
      <artifactId>jenkins-test-harness</artifactId>
-      <version>1589.vc23fca066d5c</version>
+      <version>1626.v46b0925e70db</version>


are the test failures related to updating this?

any idea why dependabot isn't updating this?

updater | INFO <job_213087289> Checking if org.jenkins-ci.main:jenkins-test-harness 1589.vc23fca066d5c needs updating proxy | 2021/09/26 19:10:19 [146] GET https://repo.jenkins-ci.org:443/public/org/jenkins-ci/jenkins/1.67/jenkins-1.67.pom proxy | 2021/09/26 19:10:19 [146] 200 https://repo.jenkins-ci.org:443/public/org/jenkins-ci/jenkins/1.67/jenkins-1.67.pom proxy | 2021/09/26 19:10:19 [148] GET https://repo.jenkins-ci.org:443/public/org/jenkins-ci/main/jenkins-test-harness/maven-metadata.xml proxy | 2021/09/26 19:10:19 [148] 200 https://repo.jenkins-ci.org:443/public/org/jenkins-ci/main/jenkins-test-harness/maven-metadata.xml proxy | 2021/09/26 19:10:19 [150] GET https://repo.maven.apache.org:443/maven2/org/jenkins-ci/main/jenkins-test-harness/maven-metadata.xml proxy | 2021/09/26 19:10:19 [150] 404 https://repo.maven.apache.org:443/maven2/org/jenkins-ci/main/jenkins-test-harness/maven-metadata.xml proxy | 2021/09/26 19:10:19 [152] HEAD https://repo.jenkins-ci.org:443/public/org/jenkins-ci/main/jenkins-test-harness/1589.vc23fca066d5c/jenkins-test-harness-1589.vc23fca066d5c.jar proxy | 2021/09/26 19:10:19 [152] 200 https://repo.jenkins-ci.org:443/public/org/jenkins-ci/main/jenkins-test-harness/1589.vc23fca066d5c/jenkins-test-harness-1589.vc23fca066d5c.jar updater | INFO <job_213087289> Latest version is 1589.vc23fca066d5c

No idea offhand.

jglick · 2021-09-13T13:44:39Z

core/src/main/java/hudson/DNSMultiCast.java

- *
- * @author Kohsuke Kawaguchi
- * @deprecated No longer does anything.
+ * @deprecated No longer does anything. Only here to prevent errors from old versions of tools like {@code JenkinsRule}.


FTR tests still run with the older JenkinsRule

diff --git test/pom.xml test/pom.xml index 1527fbcdcc..38d5934b15 100644 --- test/pom.xml +++ test/pom.xml @@ -81,7 +81,7 @@ THE SOFTWARE. <dependency> <groupId>${project.groupId}</groupId> <artifactId>jenkins-test-harness</artifactId> - <version>1626.v46b0925e70db</version> + <version>1589.vc23fca066d5c</version> <scope>test</scope> <exclusions> <exclusion>

…moveMulticast-redux

…kins into removeMulticast-redux

timja · 2021-09-27T12:33:24Z

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[JENKINS-33596] Fully delete UDPBroadcastThread & DNSMultiCast

cb041df

jglick requested a review from jeffret-b September 10, 2021 15:47

StefanSpieker approved these changes Sep 10, 2021

View reviewed changes

res0nance approved these changes Sep 10, 2021

View reviewed changes

jglick marked this pull request as draft September 10, 2021 16:30

jglick added 2 commits September 10, 2021 12:30

Will need jenkinsci/jenkins-test-harness#330

1b515b2

jenkinsci/jenkins-test-harness#330 released in https://github.com/jen…

ac0979b

…kinsci/jenkins-test-harness/releases/tag/1626.v46b0925e70db

jglick marked this pull request as ready for review September 10, 2021 16:54

timja approved these changes Sep 10, 2021

View reviewed changes

daniel-beck approved these changes Sep 10, 2021

View reviewed changes

jglick marked this pull request as draft September 10, 2021 19:57

jglick added 2 commits September 10, 2021 15:57

Merge branch 'master' of https://github.com/jenkinsci/jenkins into re…

d908a3f

…moveMulticast-redux

Try to restore binary compat for tools calling `hudson.DNSMultiCast.d…

ff6601a

…isabled = true`

jglick changed the title ~~[JENKINS-33596] Fully delete UDPBroadcastThread & DNSMultiCast~~ [JENKINS-33596] Delete more of UDPBroadcastThread & DNSMultiCast Sep 10, 2021

jglick marked this pull request as ready for review September 10, 2021 20:01

jeffret-b approved these changes Sep 10, 2021

View reviewed changes

timja reviewed Sep 13, 2021

View reviewed changes

jglick commented Sep 13, 2021

View reviewed changes

res0nance added the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 21, 2021

Merge branch 'master' into removeMulticast-redux

a6bc646

timja removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 26, 2021

timja added skip-changelog Should not be shown in the changelog unresolved-merge-conflict There is a merge conflict with the target branch. labels Sep 26, 2021

jglick removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 27, 2021

jglick added 3 commits September 27, 2021 08:24

Merge branch 'master' of https://github.com/jenkinsci/jenkins into re…

9959f3b

…moveMulticast-redux

Adjusted tests to change in wording of exception message from Jetty

7b0cede

Merge branch 'removeMulticast-redux' of https://github.com/jglick/jen…

711f3ae

…kins into removeMulticast-redux

timja approved these changes Sep 27, 2021

View reviewed changes

timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 27, 2021

oleg-nenashev approved these changes Sep 27, 2021

View reviewed changes

timja merged commit 54779c7 into jenkinsci:master Sep 28, 2021

jglick deleted the removeMulticast-redux branch September 28, 2021 12:41

This was referenced Mar 13, 2023

Remove unused hudson.udp system property jenkinsci/plugin-pom#719

Merged

Remove unused hudson.udp property jenkinsci/gerrit-trigger-plugin#486

Merged

Remove unused hudson.udp property jenkinsci/blueocean-plugin#2413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-33596] Delete more of `UDPBroadcastThread` & `DNSMultiCast` #5720

[JENKINS-33596] Delete more of `UDPBroadcastThread` & `DNSMultiCast` #5720

jglick commented Sep 10, 2021 •

edited

Loading

jglick commented Sep 10, 2021

jglick commented Sep 10, 2021

jeffret-b left a comment

jglick commented Sep 13, 2021

jeffret-b commented Sep 13, 2021

jglick commented Sep 13, 2021

timja Sep 13, 2021

timja Sep 26, 2021

jglick Sep 27, 2021

jglick Sep 13, 2021

timja commented Sep 27, 2021

[JENKINS-33596] Delete more of UDPBroadcastThread & DNSMultiCast #5720

[JENKINS-33596] Delete more of UDPBroadcastThread & DNSMultiCast #5720

Conversation

jglick commented Sep 10, 2021 • edited Loading

Proposed changelog entries

Maintainer checklist

jglick commented Sep 10, 2021

jglick commented Sep 10, 2021

jeffret-b left a comment

Choose a reason for hiding this comment

jglick commented Sep 13, 2021

jeffret-b commented Sep 13, 2021

jglick commented Sep 13, 2021

timja Sep 13, 2021

Choose a reason for hiding this comment

timja Sep 26, 2021

Choose a reason for hiding this comment

jglick Sep 27, 2021

Choose a reason for hiding this comment

jglick Sep 13, 2021

Choose a reason for hiding this comment

timja commented Sep 27, 2021

[JENKINS-33596] Delete more of `UDPBroadcastThread` & `DNSMultiCast` #5720

[JENKINS-33596] Delete more of `UDPBroadcastThread` & `DNSMultiCast` #5720

jglick commented Sep 10, 2021 •

edited

Loading