Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS variables - prerequisite for Dark mode #4752
Add CSS variables - prerequisite for Dark mode #4752
Changes from 4 commits
7606a10
611f6ad
a7934a7
a9b9310
7b04563
94b9311
cb37c39
f824f3a
670b907
78928fa
19f931d
48610d5
330b6f3
d0fbb44
86c0bd0
daf9cd3
4b5b72d
999c71f
d5398ee
23fdc52
461805f
37d2e15
fb31dd1
6627e85
f9df961
07abb84
2faf971
c12b42c
49e501f
cbfc042
fbdd4d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone able to check if this works on IE 11?
I suspect that it needs a manual fallback, looks like the postcss processor isn't adding the fallback for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work on i.e but the entire dark theme doesn't
Here is a side by side with ie11 on the left and edge on the right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not expected to work on IE 11 at all for the theme
That's not working, at least for fonts, the preprocessor isn't picking them up 😢,
Two options I guess,
cc @fqueiruga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more observations I made:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I’d forgotten about the admin monitor issue, and I hadn’t checked the CLI page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I would not bother converting the arrow to a CSS variables. It should be either an icon or a CSS triangle, not an image anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.jenkins-ci.org/browse/JENKINS-62496