[JENKINS-52914] - Allow decorating Launchers for runs, introduce a createLauncher API on the Run level #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eateLauncher API on the Run level
jglick
reviewed
Aug 10, 2018
| @@ -518,6 +555,8 @@ public Result run(@Nonnull BuildListener listener) throws Exception { | |||
| return result; | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
oleg-nenashev
added
the
needs-justification
|
Yes. Likely it needs a reference impl, e.g. in Pipeline or other plugin which creates lanchers |
batmat
added
the
unresolved-merge-conflict
|
This seems abandoned given the lack of progress and comments since August. Therefore closing as stalled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just detaching some code from #3575 which we will unlikely need in the current implementation. It may be still useful as overall generalization, please let me know if somebody finds it useful.
See JENKINS-52914.
Proposed changelog entries
Run#createLauncher()andLauncherDecorator#decorateFor(Run)APISubmitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@mention