Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-38313] - Introduce LogStorage API in the core #3575

Closed
wants to merge 37 commits into from
Closed

[JENKINS-38313] - Introduce LogStorage API in the core #3575

Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
4c6355b
Initial interface of LoggingMethod.
Sep 17, 2016
28386a5
Skeleton implementation of the remote logging extension point
oleg-nenashev Sep 17, 2016
79ef4c0
HACK: Get rid of the special symbol in order to be able to process su…
oleg-nenashev Sep 17, 2016
69a7ef4
Polish Javadoc a bit
oleg-nenashev Sep 18, 2016
5c287b3
Hide launcher complexity from plugin.
Sep 19, 2016
febb8bf
Update LoggingDefinitionLauncherWrapper.java
xyan0607 Sep 28, 2016
b0d8e64
Update LoggingMethod.java
xyan0607 Sep 28, 2016
948db76
Merge pull request #5 from xyan0607/jw-hackaton-external-logging
oleg-nenashev Oct 4, 2016
5224058
Save the progress
oleg-nenashev Oct 12, 2016
1c37b73
Merge commit 'ac05680bb6eba6efc8a825ba59fda6fbad753d22' into external…
oleg-nenashev Feb 2, 2018
5ffea98
Merge branch 'master' into external-task-logging
oleg-nenashev Jul 6, 2018
e64d206
[JENKINS-38313] - Facelift the implementation
oleg-nenashev Jul 9, 2018
d5c4651
[JENKINS-38313] - Add the LogBrowser stub
oleg-nenashev Jul 9, 2018
02fd209
[JENKINS-38313] - References to log storages and browsers are now per…
oleg-nenashev Jul 16, 2018
86d8e43
Cleanup FindBugs + Beta annotations
oleg-nenashev Jul 16, 2018
21aae74
Revert custom patches
oleg-nenashev Jul 16, 2018
d26d38a
[JENKINS-38313] - Adjust initialization logic so that Pipeline Operat…
oleg-nenashev Jul 23, 2018
5f6213e
[JENKINS-38313] - Move Launcher wrapping logic to External Logging AP…
oleg-nenashev Jul 23, 2018
da4441a
[JENKINS-38313] - Refactor LoggingMethod API to simplify the implemen…
oleg-nenashev Jul 23, 2018
b193607
[JENKINS-38313] - Align TaskListener and BuildListener API in Logging…
oleg-nenashev Jul 23, 2018
a2e0317
[JENKINS-38313] - CloseableStreaMBuildListener is not required
oleg-nenashev Jul 23, 2018
48d03e0
[JENKINS-38313] - Cleanup formatting, imports and licenses
oleg-nenashev Jul 23, 2018
f56ea7a
Add TODO from @jglick, unrestrict API
oleg-nenashev Jul 26, 2018
ac9633a
Merge commit '25da480fab1da7d2a01ab68a56faf00cae0c23b1' into external…
oleg-nenashev Jul 31, 2018
e15bdc1
Merge branch 'master' into external-task-logging
oleg-nenashev Aug 3, 2018
62024d7
[JENKINS-38313] - Move LogBrowser#getFile() default caching implement…
oleg-nenashev Aug 3, 2018
7ebcb15
[JENKINS-38313] - Introduce API For Deleting logs
oleg-nenashev Aug 3, 2018
70e154e
[JENKINS-38313] - Adapt NoopLogFile to the new API
oleg-nenashev Aug 3, 2018
44e9333
[JENKINS-38313] - Squash LogStorage code into a single class
oleg-nenashev Aug 3, 2018
ed05773
[JENKINS-38313] - Move more default implementations out of the core
oleg-nenashev Aug 6, 2018
eaa71b4
Merge commit '7b2698db89183b4d701107485db61eb36442ac25' into extloggi…
oleg-nenashev Aug 6, 2018
84158a2
[JENKINS-38131] - Implementations should be exportable
oleg-nenashev Aug 6, 2018
7c426d8
[JENKINS-38313] - stepLog() is not required for now, can be added lat…
oleg-nenashev Aug 7, 2018
6120801
[JENKINS-38313] - All LogStorage methods are now interruptable
oleg-nenashev Aug 7, 2018
f959341
[JENKINS-38313] - Generalize FileLogStorage, add a test stub
oleg-nenashev Aug 9, 2018
5e20ac9
[JENKINS-38313] - Add tests for Log storage
oleg-nenashev Aug 9, 2018
1113413
[JENKINS-52867] - Add tests for Log deletion in builds
oleg-nenashev Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/java/hudson/model/AbstractBuild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* The MIT License
*
* Copyright (c) 2004-2010, Sun Microsystems, Inc., Kohsuke Kawaguchi, Yahoo! Inc., CloudBees, Inc.
* Copyright (c) 2004-2018, Sun Microsystems, Inc., Kohsuke Kawaguchi, Yahoo! Inc.,
* CloudBees Inc., Oleg Nenashev and other contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -530,6 +531,10 @@ protected Launcher createLauncher(@Nonnull BuildListener listener) throws IOExce
final Node currentNode = getCurrentNode();
Launcher l = currentNode.createLauncher(listener);

// Produce correct logger
// TODO: Consider merging with create Launcher
l = getLogStorage().decorateLauncher(l, getBuild(), currentNode, listener);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not need this.


if (project instanceof BuildableItemWithBuildWrappers) {
BuildableItemWithBuildWrappers biwbw = (BuildableItemWithBuildWrappers) project;
for (BuildWrapper bw : biwbw.getBuildWrappersList())
Expand Down
Loading