fix bug with counting cloud executors + add support for counting clou…

[apemberton]

fix bug with counting cloud executors + add support for counting cloud and CJOC executors

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[oleg-nenashev]

🐛 It breaks the original outputs (e.g. "Total nodes" has been removed)

I also doubt it's a right place to integrate CJOC-specific code for shared slaves, because the functionality is not available in open-source. If you want to OSS such scripts for CloudBees Jenkins Platform, I suppose it should be hosted in a different way. E.g. you could add an additional source to Scriptler pointing to a CB repo.

Issues:

• Calculation of "Regular slaves" hardcodes classes to be excluded. It's not reliable
• This code won't work on client masters, because you process items directly
• Shared Clouds won't work on both CJOC and client masters

[apemberton]

@oleg-nenashev I wrote the original outputs. :) It's a script-console type script, not an actual API anyone was (should not have been, anyway) using for a coded-purpose.

I thought of the CJOC/CB closed source issue so will strip that out.

Regarding issues:

• Can you advise a better way to determine regular slaves from cloud slaves? If you saw my TODO, I cannot and am not sure one exists
• What do you mean by won't work on client masters? I have run this on client masters, on CJOC, and across masters using cluser opts
• What do you mean about shared clouds?

[apemberton]

@oleg-nenashev agreed re: the CloudBees specific script. I broke out cloudbees/jenkins-scripts for that purpose. When I have some time, I'll come back around to this one to only fix the cloud counting defect.

[imod]

@apemberton any interest in fixing this?