Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-based project view with auto-refresh #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sshelomentsev
Copy link

This pull-request is the improvement of the multijob project page with some bug-fixes.
Following:

  • A tree table that allows to open/close MultiJob projects and their phases.
  • Automatic update of table items in the build process.
  • Fix of the case. Let we have two phases:
MultiJob
      phase1
            job1
            job2
      phase2
            job1
            job2

In the current implementation, the table displays job statuses set equals, although there are different builds.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@oleg-nenashev
Copy link
Member

It seems to be rather a rewrite than an improvement. Needs a feedback from plugin maintainers

Top-level comments:

  • The PR removes many Multi-job classes, hence it is not backward compatible. Have you considered the data migration logic at least?
  • Direct bundling of font-awesome does not seem to be a great approach. Font awesome can be added into Jenkins via NPM. The new plugin pom supports it

@oleg-nenashev
Copy link
Member

On JS modules bundling https://github.com/tfennelly/jenkins-js-modules
Thanks to @recena for the link!

@hagzag
Copy link
Member

hagzag commented Aug 9, 2016

@sshelomentsev Could you please take a look after the recent changes to master ?

@sshelomentsev
Copy link
Author

sshelomentsev commented Aug 9, 2016

@hagzag Yes, I will update PR.
By the way, what do you think about increasing the required version of Jenkins to 1.609.3?
With newer versions, we can use new-promising frameworks for implementing UI. So, we can have a modern UI in which build's tree will be updating without refreshing the page.

@hagzag
Copy link
Member

hagzag commented Aug 9, 2016

Sure, you can add it to the pull request ;)
This view enhancement could be released a soon as you are ready, I already
started the 1.22 release :(

On Tue, Aug 9, 2016 at 8:55 PM Sergey Shelomentsev [email protected]
wrote:

@hagzag https://github.com/hagzag Yes, I will update PR.
By the way, what do you think about increasing the required version of
Jenkins to 1.609.3
With newer versions, we can use new-promising frameworks for implementing
UI. So, we can have a modern UI in which build's tree will be updating
without refreshing the page.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#87 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAL2CUWBeaD3ARSTIdfzF5AdBYs85_9Zks5qeL8WgaJpZM4G6G90
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants