Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't downcase the conditional in multijob job [JENKINS-27025] #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't downcase the conditional in multijob job [JENKINS-27025] #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/tikal/jenkins/plugins/multijob/MultiJobBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ private int getScmChange(AbstractProject subjob, PhaseJobsConfig phaseConfig, Ab

public boolean evalCondition(final String condition, final AbstractBuild<?, ?> build, final BuildListener listener) {
try {
return (Boolean) Eval.me(expandToken(condition, build, listener).toLowerCase().trim());
return (Boolean) Eval.me(expandToken(condition, build, listener).trim());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May break cases, which rely on the current behavior. Probably Eval should be made universal somehow

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-nenashev I'm not certain that the conditional functionality is usable while being lower cased. Most groovy code won't evaluate without correct capitalization.

} catch (Exception e) {
listener.getLogger().println("Can't evaluate expression, false is assumed.");
listener.getLogger().println(e.toString());
Expand Down Expand Up @@ -820,4 +820,4 @@ public void setContinuationCondition(
ContinuationCondition continuationCondition) {
this.continuationCondition = continuationCondition;
}
}
}