Update react-storybook to latest version to fix iframe on docs site

[halkeye]

Description

• Currently https://jenkinsci.github.io/jenkins-design-language/docs iframes the storybook pages. Unfortuatly due to an existing bug, the iframes don't work
• See Story list is empty when loading the storybook inside an IFRAME storybookjs/storybook#555
• This has already been addressed in later versions of react-storybook, so this PR just updates the dependancy

Submitter checklist

• Link to JIRA ticket in description, if appropriate.
• Change is code complete and matches issue description
• Appropriate unit or acceptance tests or explanation to why this change has no tests

Reviewer checklist

• Run the changes and verified the change matches the issue description
• Reviewed the code
• Verified that the appropriate tests have been written or valid explanation given

[michaelneale]

cc @sophistifunk @cliffmeyers look ok?

[sophistifunk]

Does this build in our cloud? Github is telling me it failed, but the URL is bad.

[michaelneale]

@sophistifunk yeah it does - but a test instance (noting to do with dogfood) wallopped the status.

@dragoonis if you push a change it shoudl trigger another build.

[michaelneale]

@dragoonis you have an invitation to be a collaborator on this repo so you can work in branches here too if that suits.

[cliffmeyers]

@michaelneale this PR doesn't show up on the PR's tab on Dogfood. Should it? Otherwise I'm not sure how to re-run the build.

[michaelneale]

I don't know either - convert it to a branch and it should rebuild.

[halkeye]

I think https://github.com/jenkinsci/jenkins-design-language/blob/master/site-publish.sh isn't part of the build anymore.

[sophistifunk]

I think https://github.com/jenkinsci/jenkins-design-language/blob/master/site-publish.sh isn't part of the build anymore.

Never was, as it doesn't work for everybody.

[scherler]

@sophistifunk what is the problem. I fixed it around a month ago when i published the last time

[sophistifunk]

IIRC, it required a specific version of git that's newer than what you get on OSX.

[scherler]

@sophistifunk yeah I added:

git merge --no-edit -s ours remotes/webpages/gh-pages --allow-unrelated-histories

--allow-unrelated-histories is to allow that merge if you are on git 2.9+

[scherler]

"@kadira/storybook": "2.35.3" please do not use ^

[cliffmeyers]

I was thinking, should we write a utility that validates package.json for semver best practices. My feeling is that deps and devDeps should use exact, but peerDeps should use caret operator. We could create a standalone util for use in JDL but also bake it into js-builder by default. Or maybe something comparable already exists, can look. WDYT @scherler ?

[halkeye]

Doesn't yarn.lock handle that anyways? I can't fix this or on mobile so I'll try and get to it asap

No longer uses caret

[michaelneale]

@halkeye yarn isn't in use yet (and probably better to be explicit, like you have been).

@scherler package.json has been updated.

[michaelneale]

ping @scherler @sophistifunk can we merge this one in now?

[sophistifunk]

Definitely

[michaelneale]

nice one @halkeye !

swish