Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply upcoming core styling to file upload #157

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

timja
Copy link
Member

@timja timja commented Dec 29, 2022

see jenkinsci/jenkins#7452

(untested but should be fine from what I can see in the PR as most of the inputs didn't have classes before)

@timja timja requested a review from a team December 29, 2022 12:53
Copy link
Member

@felfert felfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question about the TODO comment:

Can you be more specific about what exactly will have to be changed into an f:file
The input tag or the wrapping f:entry?

@timja
Copy link
Member Author

timja commented Jan 12, 2023

The input tag or the wrapping f:entry?

The input tag, is that TODO clearer?

@felfert felfert merged commit 23b528f into jenkinsci:master Jan 12, 2023
@felfert
Copy link
Member

felfert commented Jan 12, 2023

Yes. perfect. Thank you

@timja timja deleted the style-file-upload branch January 12, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants