Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure both tokenCache and tokenExpiryCache are initialized if needed #342

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Make sure both tokenCache and tokenExpiryCache are initialized if needed #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...va/com/datapipe/jenkins/vault/credentials/AbstractVaultTokenCredentialWithExpiration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
@Override
public Vault authorizeWithVault(VaultConfig config, List<String> policies) {
// Upgraded instances can have these not initialized in the constructor (serialized jobs possibly)
if (tokenCache == null) {
if (tokenCache == null || tokenExpiryCache == null) {

Check warning on line 110 in src/main/java/com/datapipe/jenkins/vault/credentials/AbstractVaultTokenCredentialWithExpiration.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 110 is only partially covered, 2 branches are missing
tokenCache = new HashMap<>();
tokenExpiryCache = new HashMap<>();
}
Expand Down