Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect build scans in pipeline logs #71

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Detect build scans in pipeline logs #71

merged 4 commits into from
Jul 5, 2019

Conversation

wolfs
Copy link
Member

@wolfs wolfs commented Jun 10, 2019

by using a separate step.

@wolfs wolfs self-assigned this Jun 10, 2019
@wolfs wolfs force-pushed the wolfs/build-scan-pipeline-support branch 2 times, most recently from f573458 to 7a06a22 Compare June 11, 2019 06:32
jjohannes
jjohannes approved these changes Jun 12, 2019
View reviewed changes
Copy link

@jjohannes jjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation lgtm. It would be good if you also add test coverage for the feature.

@wolfs
Detect build scans in pipeline logs
59924eb 
by using a separate step.
@wolfs wolfs force-pushed the wolfs/build-scan-pipeline-support branch from 7a06a22 to 59924eb Compare June 22, 2019 15:34
@wolfs wolfs force-pushed the wolfs/build-scan-pipeline-support branch from 3887863 to bfc3c1e Compare July 4, 2019 21:38
@wolfs wolfs force-pushed the wolfs/build-scan-pipeline-support branch from bfc3c1e to aa09b3b Compare July 4, 2019 21:52
@wolfs wolfs merged commit a8680c0 into jenkinsci:master Jul 5, 2019
@wolfs wolfs deleted the wolfs/build-scan-pipeline-support branch July 5, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjohannes jjohannes jjohannes approved these changes

Assignees

@wolfs wolfs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfs @jjohannes