Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses for the pom generation. #83

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Add licenses for the pom generation. #83

merged 2 commits into from
Dec 1, 2016

Conversation

slide
Copy link
Member

@slide slide commented Nov 25, 2016

Added the ability to specify a license that will be in the generated pom.

@slide
Copy link
Member Author

slide commented Nov 25, 2016

This is in preparation for a gradle plugin for checking plugin hosting requirements. A license is one of the things that we request for hosting.

@slide
Copy link
Member Author

slide commented Nov 27, 2016

Initial code for the hosting checker is here: https://github.com/slide/gradle-hosting-checker-plugin

@batmat take a look if you are interested

@batmat
Copy link
Member

batmat commented Nov 27, 2016

\o/ very cool @slide ! LGTM, though I'm really not gradle-fluent at all.

Seems like @daspilker is the current maintainer or main committer? cc @abayer ?

Thanks!

@daspilker daspilker merged commit 19fe0db into jenkinsci:master Dec 1, 2016
@daspilker
Copy link
Member

Cool thanks, it just needed some tweaks (7c723c4).

@slide
Copy link
Member Author

slide commented Dec 2, 2016

Thanks for the tweaks and the merge!

@slide
Copy link
Member Author

slide commented Dec 2, 2016

Just out of curiosity, do you know when the next release including these changes will be?

@daspilker
Copy link
Member

Released as 0.21.0 just now. Btw, what's your plan with the hosting checker plugin? Would it make sense to integrate it into the JPI plugin? Why does it need to be a separate plugin?

@slide
Copy link
Member Author

slide commented Dec 2, 2016

It's possible that hosting requirements will evolve more quickly than the JPI plugin would need to be released, so I made it a separate plugin for that reason. Thanks for the release.

@daspilker
Copy link
Member

We can do quick JPI plugin releases. Or how about publishing the rules as a library and let the JPI plugin depend on the latest version? Having the rules as a build-tool-neutral library is probably a good idea anyway if you want to use the same rules from the Maven plugin as well.

@slide
Copy link
Member Author

slide commented Dec 2, 2016

@daspilker All good points. @batmat what do you think about a common rule library?

@batmat
Copy link
Member

batmat commented Dec 2, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants