Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve missing coreVersion error message #152

Closed
wants to merge 1 commit into from
Closed

improve missing coreVersion error message #152

wants to merge 1 commit into from

Conversation

matejdro
Copy link

@matejdro matejdro commented Mar 5, 2020

Fixes #148

@sghill
Copy link

sghill commented Mar 5, 2020

Thanks!

I'm open to this, but it has the drawback of only failing on the server task. Considering whether there is something more explicit we can do in JpiExtension, and if the coreVersion property should just be a hard requirement to use the plugin.

@matejdro
Copy link
Author

matejdro commented Mar 6, 2020

I think you are correct. Or at least mention testing functionality when coreVersion is specified somewhere in the README as a feature. Otherwise it is pretty obscure.

@sghill sghill closed this in ed077cb May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message for running server task when coreVersion is not specified
2 participants
@matejdro @sghill