Handle deprecated Gradle properties of "jar" and "war" task #124
Conversation
There was a problem hiding this comment.
Thank you for these enhancements! I appreciate adding the fallback code to keep this plugin backwards-compatible. There are a couple things I'd like to have addressed before merging and getting this released.
Additionally, if you'd like to update the IntegrationSpec to ensure we're not shipping anything deprecated in the future, I think that would fit well with this change. I tried adding this locally and found dozens of tests failed for these two deprecated properties:
def setup() {
projectDir.newFile('gradle.properties') << 'org.gradle.warning.mode=fail'
}It uses Gradle's ability to fail on warnings so we'll notice these issues sooner.
src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPluginSpec.groovy
Outdated
Show resolved
Hide resolved
…ension" The following output was shown when running `gradle help --warning-mode all` for a Jenkins plugin that is based on this one: > The archiveName property has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the archiveFileName property instead. > The extension property has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the archiveExtension property instead. These new properties are implemented as `Property` instead of `String` now. Therefore the `set()` calls.
This new property is implemented as `Property` instead of `String` now. Therefore the `set()` call.
darxriggs
force-pushed
the
deprecated-properties
branch
from
e30f50f to
4158f7d
Compare
|
Thanks for the very useful hints. I now spent some time on the issues after enabling Unfortunately I am not familiar enough with the plugin and all the changes/deprecations in Gradle regarding dependency resolution to prepare all the required changes. I just added another commit which is about the "jar" task as this is well understood. |
darxriggs
changed the title
|
This looks great, thanks for the quick turnaround!
No worries, 👍 for looking into it. |
|
This has been released in 0.36.0. |
The following output was shown when running
gradle help --warning-mode allfor a Jenkins plugin that is based on this one:This is to resolve these warnings.