Put work directory inside project directory #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the rootDir was used as parent for the work directory. This led to the situation where a subproject containing a jenkins plugin put the work directory at the top of the project hierarchy. This becomes especially problematic when several jenkins plugins are managed from one root projects. This change uses `project.projectDir` instead which will be the same as `project.rootDir` for projects without sub projcts but will be the actual project directory for nested projects.
|
@sghill is this project still active? I have some more, bigger changes I'd like to propose :-) |
wolfs
approved these changes
Jun 22, 2019
|
@britter it’s still active. Open to larger changes, but strong preference for backwards compatibility. Thanks for the contribution! |
|
This change is now released in v0.33.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the rootDir was used as parent for the work directory. This
led to the situation where a subproject containing a jenkins plugin put
the work directory at the top of the project hierarchy. This becomes
especially problematic when several jenkins plugins are managed from one
root projects.
This change uses
project.projectDirinstead which will be the same asproject.rootDirfor projects without sub projcts but will be theactual project directory for nested projects.