Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server Task Leaves Behind Old Plugins #165

Closed
sghill opened this issue May 16, 2020 · 1 comment
Closed

server Task Leaves Behind Old Plugins #165

sghill opened this issue May 16, 2020 · 1 comment

Comments

@sghill
Copy link

sghill commented May 16, 2020

In order to remove plugins effectively
As a plugin developer
I want the gradle-jpi-plugin to remove plugins from the work directory when they are removed from dependencies

Given I have a build.gradle like this:

plugins {
  id 'org.jenkins-ci.jpi' version '0.39.0'
}

jenkinsPlugin {
  coreVersion = '2.222.3'
}

dependencies {
  implementation 'org.jenkins-ci.plugins:git:4.0.1'
}

When I run ./gradlew server the git plugin
Then its dependencies are installed to work/plugins
When I remove the plugin and add another
Then the old plugin still remains in work/plugins
And is loaded by Jenkins

sghill added a commit that referenced this issue May 16, 2020
- #165 Introduce InstallJenkinsServerPluginsTask to sync plugins from
  project dependencies to $workDir/plugins
- #136 Introduce GenerateJenkinsServerHplTask and test through TestKit
- Introduce ProjectFile.Builder and friends to improve readability of
  tests
@sghill
Copy link
Author

sghill commented May 16, 2020

Fixed in the referenced commit by turning the copy plugins method into its own Sync task.

@sghill sghill closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant