Skip to content

Commit

Permalink
Update CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
@sghill
sghill committed Feb 4, 2020
1 parent df6621b commit c21a7a1
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
## 0.39.0 (unreleased)

This comment has been minimized.

Sign in to view

Copy link
@darxriggs

darxriggs Feb 4, 2020 •
edited
Loading

I am looking forward to this release. After all these changes maybe an issue is fixed, I recently introduced in 0.36.0.

In pull request #123 I had to change the classpath of the "war" task to not contain the main output (resources and class files) anymore (see here) but to use the .jar file instead (see here).

Unfortunately long time ago since pull request #43 the .hpl file generated uses the JPI/WAR classpath instead of the runtime classpath. Therefore running ./gradlew server now fails to load the plugin (e.g. groovy-events-listener-plugin) because neither the classes nor the .jar file is configured in .hpl file.

//CC @jjohannes @wolfs

This comment has been minimized.

Sign in to view

Copy link
@sghill

sghill Feb 4, 2020

Author

0.39.0-rc.1 has been published for testing. If you’d like to try it out and report back, that’d be appreciated @darxriggs!

This comment has been minimized.

Sign in to view

Copy link
@darxriggs

darxriggs Feb 4, 2020

I am already having a look at it. The groovy-events-listener-plugin still fails with this version when running the server task (after changing jenkinsTest to testImplementation and war to jpi in the build.gradle file).

The code is again using the runtime classpath (like before pull request #43) - see here. Therefore the .hpl is missing the Library entries for the Groovy and Ivy jar file.

@jjohannes can you have a look at it?

This comment has been minimized.

Sign in to view

Copy link
@wolfs

wolfs Feb 5, 2020

Member

The server task for the gradle-plugin work fine for me when using the new version, see this PR: jenkinsci/gradle-plugin#99

This comment has been minimized.

Sign in to view

Copy link
@jjohannes

jjohannes Feb 5, 2020

Thanks @darxriggs for reporting. Looks like there are no tests for that part and I (unintentionally) changed what you pointed out. I'll provide a fix.

This comment has been minimized.

Sign in to view

Copy link
@jjohannes

jjohannes Feb 5, 2020

I have addressed the issues here: #135

@darxriggs The issue with the HPL manifest should be fixed now (it now uses classses/resources again). I have tested it with the 'groovy-events-listener-plugin' and it seems to work for me.

You have to replace:

jpi {
    classpath configurations.forceGroovy // add the Groovy lib to the plugin to make @Grab work
}

with a normal dependency:

implementation 'org.codehaus.groovy:groovy-all:2.4.8'

This comment has been minimized.

Sign in to view

Copy link
@darxriggs

darxriggs Feb 5, 2020 •
edited
Loading

LGTM, see my #135 (comment).

This comment has been minimized.

Sign in to view

Copy link
@jjohannes

jjohannes Feb 6, 2020

Thanks @darxriggs 👍

This comment has been minimized.

Sign in to view

Copy link
@wolfs

wolfs Feb 7, 2020

Member

RC2 works well for the Gradle plugin: jenkinsci/gradle-plugin#99

This comment has been minimized.

Sign in to view

Copy link
@darxriggs

darxriggs Feb 12, 2020

@sghill Is there timeline for a final release?

This comment has been minimized.

Sign in to view

Copy link
@sghill

sghill Feb 12, 2020

Author

@darxriggs no firm date as of now, expecting a couple weeks.

Since this includes a number of breaking changes, I’d like to have some upgrade examples to serve as a migration guide (#139) first. If you’d like to link your upgrade diff there, that’d be really helpful.

This comment has been minimized.

Sign in to view

Copy link
@sghill

sghill Apr 16, 2020

Author

0.39.0 is now released.

* use variant-aware dependency management - [PR #132](https://github.com/jenkinsci/gradle-jpi-plugin/pull/132), allowing
publication of Gradle Module Metadata
* requires Gradle 6.0 or later
* remove `jenkinsPlugins` in favor of using `implementation`
* remove `optionalJenkinsPlugins` in favor of using [Gradle feature variants](https://docs.gradle.org/6.1.1/userguide/feature_variants.html)
* remove `jenkinsTest` in favor of using `testImplementation`

## 0.38.0 (2020-01-27)

* upgrade dependency `org.jenkins-ci.main:jenkins-test-harness:2.31 -> 2.60` added to projects - [PR #133](https://github.com/jenkinsci/gradle-jpi-plugin/pull/133)
Expand Down

0 comments on commit c21a7a1

Please sign in to comment.