Whitelist fix #73
Merged
Whitelist fix #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght it to standards
…instance variable to the top
src/main/java/com/google/jenkins/plugins/storage/AbstractUpload.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/jenkins/plugins/storage/AbstractUpload.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/jenkins/plugins/storage/AbstractUpload.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/jenkins/plugins/storage/ClassicUploadStep.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/jenkins/plugins/storage/ClassicUploadStep.java
Outdated
Show resolved
Hide resolved
stephenashank
pushed a commit
that referenced
this pull request
Jul 9, 2019
* Made UploadModule transient to resolve deserialization security issue with JEP-200 * Made UploadModule not serializable and cleaned up abstractUpload/brought it to standards
stephenashank
pushed a commit
that referenced
this pull request
Jul 9, 2019
This reverts commit 6e45934.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue with JEP-200 when we upgrade Jenkins to 2.164.
To summarize, after 2.102, classes that needed to be deserialized had to be whitelisted by Jenkins.
DownloadStepTest was having issues passing because MockExecutor had a non-whitelisted class to serialize (Storage.model.Objects).
By making the UploadModule transient, it is not deserialized and resolves the issue. UploadModule contains helper functions only and thus would not need to be serializable. This will also not be an issue once #71 is complete.
Also added method headers to all the steps if not already there.
Passed mvn verify.