Register XStream alias even earlier #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change in the git plugin that somehow makes
GitHubPluginConfig
load earlier thanGitHubPlugin.start()
So when running the
MigratorTest
with git plugin 4.12.1 installed (for example during PCT) it fails because the old configuration could not be loaded.The fix is simply to register the XStream alias before
InitMilestone.SYSTEM_CONFIG_LOADED
instead ofGitHubPlugin.start()
.I've verified that it works by temporarily adding the git plugin as a test dependency in the pom of this plugin, and the
MigratorTest
fails before this change and succeeds after the fix got applied.