Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register XStream alias even earlier #304

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

rsandell
Copy link
Member

@rsandell rsandell commented Oct 18, 2022

There has been a change in the git plugin that somehow makes GitHubPluginConfig load earlier than GitHubPlugin.start()
So when running the MigratorTest with git plugin 4.12.1 installed (for example during PCT) it fails because the old configuration could not be loaded.

The fix is simply to register the XStream alias before InitMilestone.SYSTEM_CONFIG_LOADED instead of GitHubPlugin.start().

I've verified that it works by temporarily adding the git plugin as a test dependency in the pom of this plugin, and the MigratorTest fails before this change and succeeds after the fix got applied.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@KostyaSha KostyaSha merged commit 06f3466 into jenkinsci:master Oct 19, 2022
@Dohbedoh
Copy link
Contributor

Apparently this causes some initialization issue https://issues.jenkins.io/browse/JENKINS-70351.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants