Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to enable authentication with used HTTP proxy ( JENKINS-67806 ) #264

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix to enable authentication with used HTTP proxy ( JENKINS-67806 ) #264

merged 2 commits into from
Feb 24, 2022

Conversation

thecooldrop
Copy link

Currently the Github plugin can not reach the Github server if the proxy used
by Jenkins requires authentication. Reason for that lies in the missing
configuration of proxy authenticator for the Github plugin.

This commit should resolve that issue by introducing a new HTTP client which is
preconfigured to handle the usage of Jenkins proxy configurations

This commit should resolve issue JENKINS-67806

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Currently the Github plugin can not reach the Github server if the proxy used
by Jenkins requires authentication. Reason for that lies in the missing
configuration of proxy authenticator for the Github plugin.

This commit should resolve that issue by introducing a new HTTP client which is
preconfigured to handle the usage of Jenkins proxy configurations

This commit should resolve issue JENKINS-67806
@thecooldrop
Copy link
Author

Hi @KostyaSha, may I ask you to check this PR out, as this is blocking us from fully migrating Jenkins into new infrastructure?

@KostyaSha KostyaSha merged commit 4c21b36 into jenkinsci:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants