Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JDK11 in Jenkinsfile #257

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Oct 13, 2021

Hello 👋

Here is a simple PR enabling JDK11 in the Jenkinsfile of this plugin, helping the global support of Java 11 in Jenkins plugins.

Please let me know if anything needs to be updated or if I missed something. Thanks a lot!

On my side, I validated that compilation + tests were running fine with JDK11. I could not validate the execution on Jenkins though, hence just modifying the Jenkins file and following the CI execution here.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@KostyaSha
Copy link
Member

Shouldn't this configurations be just enabled in buildPlugin shared library by default?

@amuniz
Copy link
Member

amuniz commented Nov 3, 2021

Shouldn't this configurations be just enabled in buildPlugin shared library by default?

jenkins-infra/pipeline-library#145

@KostyaSha KostyaSha merged commit 344f2a1 into jenkinsci:master Jan 10, 2022
@batmat batmat requested review from bitwiseman and removed request for bitwiseman January 27, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants