add field for setting context for pending step #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please add |
lanwen
requested changes
Nov 21, 2016
| return contextSource; | ||
| } | ||
|
|
||
| /** | ||
| * @since 1.14.1 | ||
| */ | ||
| @DataBoundSetter | ||
| public void setStatusMessage(ExpandableMessage statusMessage) { | ||
| this.statusMessage = statusMessage; | ||
| } | ||
|
|
There was a problem hiding this comment.
please add since FIXME javadoc tag, i'll fix actual version before release
|
I've updated the code per the requested changes. Should I squash some of these commits? |
|
No, github can squash by itself |
lanwen
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the pending step with the context field also available in the after build step.
But I couldn't get the failing test updated to make it work again, so if anyone can give me some pointers there?
I'm totally new to java, and somethings are easy to derive from existing code, but I actually have no idea what I'm doing 💩. But the implementation is functional in my installation.
This change is