Add support for proxy #15
Conversation
|
Jenkins » github-oauth-plugin #44 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Sorry for neglecting to look at this PR, but thanks for sending it over. I'll test it out tomorrow and merge if all looks good. |
| * Returns the proxy to be used when connecting to the given URI. | ||
| */ | ||
| private HttpHost getProxy(String uri) { | ||
| if (uri == null) { |
There was a problem hiding this comment.
I'd rather have this validation be on the UI level. Would you mind doing input validation instead of this kind of check?
There was a problem hiding this comment.
I am not sure what you mean - we can remove the check if it seems unnecessary, but do you want anything else to be checked instead?
|
Great work, guys. I came into this issue when my ISP got some problems connecting to github's servers. It would be great to ship this patch, so I can set proxy via java command line params. just some references here, for other non-java people who need to use proxy with this plugin: |
Conflicts: src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
Using the same method as the Java Http library does - it is necessary to use -Dhttp.proxyHost, etc because of the underlying Git library, so now these properties are also picked up by the plugin, giving support for authless proxies.