GitHub Enterprise

[johnou]

Proposed fix for GitHub Enterprise, discussion at hub4j/github-api#29

[buildhive]

Jenkins » github-oauth-plugin #8 SUCCESS
This pull request looks good
(what's this?)

[johnou]

@mocleiri what are your thoughts?

[mocleiri]

Thanks for your contribution to the plugin.

This other commit (ff357ac) you made seems to break non github enterprise users, see here:
https://issues.jenkins-ci.org/browse/JENKINS-16492

Does this pull request fix both issues from the 0.13 release?

I've just handed off the maintainer-ship of this plugin to @skottler so hopefully he can comment on this.

If both don't work then probably a checkbox in the plugin settings would be the way to go to support both cases.

[buildhive]

Jenkins » github-oauth-plugin #10 SUCCESS
This pull request looks good
(what's this?)

[skottler]

Thanks @johnou! I poke with some folks over at Github about getting a testing instance, which I should have access to in the next few days so I can try this out.

[johnou]

@skottler let me know if you get a better response..

Austin Spires (GitHub Enterprise)
Jan 14 10:06 am (PST)

Hi Johno,

Unfortunately, we aren't able to issue evaluation licenses to individuals at this time. However, from an integration perspective, the Enterprise API is identical to the GitHub.com API, so you may not need access to an Enterprise instance for testing purposes alone.

Thanks,

-Austin

Austin Spires
Enterprise Accounts
GitHub

[skottler]

I personally some employees over there so they've have already agreed to give me an instance. I'm just waiting to hear back about access details.

[leftathome]

Hi guys,

I'm going to give this plugin a spin. I have access to a couple of (firewalled) GitHub Enterprise instances. Let me know if I can be of any assistance in testing the plugin or helping things along with the GitHub people.

[johnou]

@skottler how's it looking?

[bjeanes]

@skottler bump! I have access to a GHE instance here and we are using a vendored version of this library with a change much like this. I'll try to replace it wholesale with this version to see if things still work, if you haven't managed to get ahold of a GHE yourself yet.

[bjeanes]

Is this dependency version drop a necessary part of this change?

[johnou]

See #11