Skip to content

Commit

Permalink
Unneeeded check as githubWebUri is guaranteed non-null at this point.
Browse files Browse the repository at this point in the history
Personally, I'm fine with having a defensive check like this, but @skottler didn't seem to like this in a review comment in https://github.com/jenkinsci/github-oauth-plugin/pull/15/files so I'm respecting his opinion by removing this check.
  • Loading branch information
kohsuke committed Jul 3, 2014
1 parent c6ad077 commit b40fb3d
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,6 @@ public HttpResponse doFinishLogin(StaplerRequest request)
* Returns the proxy to be used when connecting to the given URI.
*/
private HttpHost getProxy(String uri) {
if (uri == null) {
return null;
}

String prefix = uri.startsWith("https") ? "https" : "http";
String proxyHost = System.getProperty(prefix + ".proxyHost");
if (StringUtils.isBlank(proxyHost)) {
Expand Down

0 comments on commit b40fb3d

Please sign in to comment.