Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbols for SCM traits #289

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

jonesbusy
Copy link
Contributor

Hi,

Add symbols to avoid using configure block when configuring those traits via JobDSL

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

github_check_status

github_check_source

Regards,

@jonesbusy jonesbusy requested a review from a team as a code owner August 31, 2022 05:35
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #289 (5dcd5bc) into master (1f6579c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #289   +/-   ##
=========================================
  Coverage     80.79%   80.79%           
  Complexity      170      170           
=========================================
  Files            16       16           
  Lines           526      526           
  Branches         49       49           
=========================================
  Hits            425      425           
  Misses           79       79           
  Partials         22       22           
Impacted Files Coverage Δ
...ecks/github/config/GitHubSCMSourceChecksTrait.java 22.22% <ø> (ø)
...ithub/status/GitHubSCMSourceStatusChecksTrait.java 75.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timja timja added the enhancement New feature or request label Sep 3, 2022
@timja timja merged commit 640f7a4 into jenkinsci:master Sep 3, 2022
@jonesbusy jonesbusy deleted the feature/job-dsl-symbol branch September 4, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants