Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head branch is not sent for forks #237

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

timja
Copy link
Member

@timja timja commented Jan 15, 2022

@timja timja added the bug Something isn't working label Jan 15, 2022
@timja timja requested a review from a team as a code owner January 15, 2022 10:12
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #237 (0a030fe) into master (9efc8d6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     80.19%   80.30%   +0.11%     
- Complexity      168      169       +1     
============================================
  Files            16       16              
  Lines           520      523       +3     
  Branches         47       48       +1     
============================================
+ Hits            417      420       +3     
  Misses           81       81              
  Partials         22       22              
Impacted Files Coverage Δ
...ugins/checks/github/CheckRunGHEventSubscriber.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efc8d6...0a030fe. Read the comment docs.

@timja timja force-pushed the head_branch_is_optional branch from 0ab4748 to 0a030fe Compare January 15, 2022 10:25
@timja timja merged commit f35f09a into jenkinsci:master Jan 15, 2022
@timja timja deleted the head_branch_is_optional branch January 15, 2022 11:16
@jglick
Copy link
Member

jglick commented Jan 15, 2022

Any idea why it is not present?

@timja
Copy link
Member Author

timja commented Jan 15, 2022

Any idea why it is not present?

https://docs.github.com/en/rest/reference/checks#suites

Note: The Checks API only looks for pushes in the repository where the check suite or check run were created. Pushes to a branch in a forked repository are not detected and return an empty pull_requests array and a null value for head_branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants