JENKINS-56996 - PRs where parts are not found are orphaned #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad PRs can happen a number of ways when constituent parts of the PR were missing, source fork, user, target branch, etc. The generally mean the PR is permanenently dead. However, before this change one bad PR would throw an exception and crash an entire scan. In the case of GitHub Org Folder Pipelines this would happen all too easily and would stop the whole org from scanning. This change treats the FileNotFound exceptions thrown by these bad PRs as errors local to the PR, treats them as orphaned, and continues the scan. This change only effects PRs, not tags or branches, which are less prone to errors (or are already doing a similiar thing).
abayer
approved these changes
May 7, 2019
kshultzCB
approved these changes
May 8, 2019
| try { | ||
| commit = repo.getCommit(this.mergeHash); | ||
| } catch (FileNotFoundException e) { | ||
| throw new AbortException("Invalid merge hash for pull request " + ((PullRequestSCMHead)this.getHead()).getNumber() + " : commit not found (" + this.mergeHash + "). Try close and reopen this PR to reset merge hash."); |
There was a problem hiding this comment.
Sentence fragment: Try close and reopen this PR to reset merge hash. Wordy version might be Try closing and reopening this PR to reset its merge hash. Terse version might be Close and reopen the PR to reset its merge hash.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad PRs can happen a number of ways when constituent parts of
the PR were missing, source fork, user, target branch, etc.
The generally mean the PR is permanently dead.
However, before this change one bad PR would throw an exception
and crash an entire scan. In the case of GitHub Org Folder Pipelines
this would happen all too easily and would stop the whole org from scanning.
This change treats the FileNotFound exceptions thrown by these bad PRs
as errors local to the PR, treats them as orphaned, and continues the scan.
This change only effects PRs, not tags or branches, which are
less prone to errors (or are already doing a similar thing).