-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize to Jenkins 2.479 and Jakarta EE 9 #134
base: master
Are you sure you want to change the base?
Conversation
b3662b9
to
9549307
Compare
Trying to figure out why SpotBugs is errantly flagging a |
9549307
to
e35fb41
Compare
e35fb41
to
ba97a8c
Compare
ba97a8c
to
91bdae0
Compare
@@ -40,48 +41,50 @@ | |||
*/ | |||
@Extension | |||
public class CSRFExclusionImpl extends CrumbExclusion { | |||
private static final Set<String> ALLOWED_CONTENT_TYPES = Set.of( | |||
"application/x-git-receive-pack-request", | |||
"application/x-git-upload-pack-request" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that this content type has been missing for who knows how long, so CSRF protection would have blocked any Git fetches to a repository. Given that, I'm going to probably add functionality to the Scriptler plugin to enable/disable the Git repository (defaulting to disabled) and see what happens. I'm suspecting that no one uses it.
SSH access still works, but I feel like that would be less commonly used because you'd also have to enable the SSH server within Jenkins first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just read the comments in #112 about HTTP access. Without knowing more about HTTP access, I'm removing this part from the commit and it can be dealt with separately.
90bd3d1
to
0d96613
Compare
0d96613
to
bfb36e4
Compare
* Adapter methods are added for old overrides. * Switch to JUnit 5 for tests
bfb36e4
to
f4a410b
Compare
@jenkinsci/git-server-plugin-developers, please review when able. |
Required for the Scriptler plugin to modernize as well without breaking SSH compatibility.
Testing done
Unit tests updated and run.
Submitter checklist