Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest parent pom, test with JCasC and BOM #746

Merged
merged 7 commits into from
Aug 27, 2019
Merged

Use latest parent pom, test with JCasC and BOM #746

merged 7 commits into from
Aug 27, 2019

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 27, 2019 •
edited
Loading

Use latest parent pom and JCasC

Use latest parent pom.

Test with latest configuration as code plugin and use the plugin BOM to set the versions of many of the test components. Rely on the plugin bom to track latest supported versions for the required jenkins.version .

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Dependency or infrastructure update

@MarkEWaite MarkEWaite added the skip-changelog Exclude from the changelog label Aug 27, 2019
@MarkEWaite MarkEWaite changed the title Use latest parent pom and JCasC Use latest parent pom and JCasC and BOM Aug 27, 2019
@MarkEWaite MarkEWaite changed the title Use latest parent pom and JCasC and BOM Use latest parent pom, test with JCasC and BOM based deps Aug 27, 2019
@MarkEWaite MarkEWaite changed the title Use latest parent pom, test with JCasC and BOM based deps Use latest parent pom, test with JCasC and BOM Aug 27, 2019
This was referenced Aug 27, 2019
Closed
Closed
@jglick
Copy link
Member

jglick commented Aug 27, 2019

Did you check the failure in GitJCasCCompatibilityTest.roundTripTest encountered in jenkinsci/bom#78?

The log should have 'Setting class hudson.plugins.git.GitSCM.submoduleCfg = [{}, {}]'

@MarkEWaite
Copy link
Contributor Author

Did you check the failure in GitJCasCCompatibilityTest.roundTripTest encountered in jenkinsci/bom#78?

The log should have 'Setting class hudson.plugins.git.GitSCM.submoduleCfg = [{}, {}]'

Yes. That test failure is fixed in git client plugin 2.8.2.

@MarkEWaite MarkEWaite merged commit 2db5cbf into jenkinsci:stable-3.x Aug 27, 2019
@MarkEWaite MarkEWaite deleted the update-pom branch August 27, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@jglick jglick jglick approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

Assignees
No one assigned
Labels
skip-changelog Exclude from the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkEWaite @jglick @dwnusbaum