-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73677] Decorate GitClient after adding credentials #1649
Conversation
@jenkinsci/git-plugin-developers Any chance to get this merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[JENKINS-73677] Decorate GitClient after adding credentials jenkinsci/git-plugin#1649
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOM tests passed with this change. Ready to merge and release
…enkinsci#1649)" This reverts commit 843d48b.
…1649)" https://issues.jenkins.io/browse/JENKINS-73797 reports that Bitbucket branch source plugin multibranch Pipelines are broken by this change if they use ssh access to the repository. Rather than disrupt users by breaking their Pipelines, revert the change and release it so that we have time to evaluate alternatives and to develop better tests. This reverts commit 843d48b.
Appears to have broken Bitbucket Branch Source plugin Multibranch Pipeline jobs if they use SSH access to the repository: JENKINS-73797 |
JENKINS-73677: Credentials are added to GitClient after the client is decorated by extensions.. A plugin cannot for example override the credentials passed in via a GitSCMExtension (Noticed as part of jenkinsci/bitbucket-branch-source-plugin#867)
Testing done
Tested simple scenario: configured Pipeline from SCM with GitSCM with provided Credentials.
Submitter checklist