add junit test for stash file parameter

README.md

@@ -70,12 +70,12 @@ pipeline {
   - [X] implementation
   - [ ] manual test
   - [ ] automated test
-- [ ] `withFileParameter` wrapper step
+- [X] `withFileParameter` wrapper step
   - [X] implementation
   - [X] inline help text
   - [X] manual test
   - [X] automated test
-  - [ ] option to tolerate undefined parameter
+  - [X] option to tolerate undefined parameter
 - [ ] `input` step submission
   - [ ] design
   - [ ] manual test

src/main/java/io/jenkins/plugins/file_parameters/FileParameterWrapper.java

@@ -41,6 +41,7 @@
 import jenkins.tasks.SimpleBuildWrapper;
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
+import org.kohsuke.stapler.DataBoundSetter;
 
 /**
  * Saves a file parameter to a temporary local file.
@@ -49,22 +50,37 @@ public final class FileParameterWrapper extends SimpleBuildWrapper {
 
     public final String name;
 
+    private boolean allowNoFile;
+
     @DataBoundConstructor public FileParameterWrapper(String name) {
         this.name = name;
     }
 
+    public boolean isAllowNoFile() {
+        return allowNoFile;
+    }
+
+    @DataBoundSetter
+    public void setAllowNoFile(boolean allowNoFile) {
+        this.allowNoFile = allowNoFile;
+    }
+
     @Override public void setUp(Context context, Run<?, ?> build, FilePath workspace, Launcher launcher, TaskListener listener, EnvVars initialEnvironment) throws IOException, InterruptedException {
         ParametersAction pa = build.getAction(ParametersAction.class);
         if (pa == null) {
             throw new AbortException("No parameters");
         }
         ParameterValue pv = pa.getParameter(name);
-        if (pv == null) {
+        if (pv == null && !allowNoFile) {
             throw new AbortException("No parameter named " + name);
         }
-        if (!(pv instanceof AbstractFileParameterValue)) {
+        if (!(pv instanceof AbstractFileParameterValue) && !allowNoFile) {
             throw new AbortException("Unsupported parameter type");
         }
+        if (pv == null && allowNoFile) {
+            listener.getLogger().println("Skip file parameter as there is no parameter with name: '" + name + "'");
+            return;
+        }
         FilePath tempDir = WorkspaceList.tempDir(workspace);
         if (tempDir == null) {
             throw new AbortException("Missing workspace or could not make temp dir");

src/main/java/io/jenkins/plugins/file_parameters/StashedFileParameterDefinition.java

@@ -51,7 +51,7 @@ public final class StashedFileParameterDefinition extends AbstractFileParameterD
     @Extension public static final class DescriptorImpl extends ParameterDefinition.ParameterDescriptor {
 
         @Override public String getDisplayName() {
-            return "Stashed Base64 File Parameter";
+            return "Stashed File Parameter";
         }
 
     }

src/main/resources/io/jenkins/plugins/file_parameters/Base64FileParameterDefinition/help.html

@@ -18,3 +18,24 @@
 }
   </pre>
 </div>
+<div>
+  Per default, there will be an error if there is no parameter for the build but you can ignore this error using the
+  parameter attribute <code>allowNoFile</code>. In this case your pipeline must take into account the file doesn't exists
+  <pre>
+pipeline {
+  agent any
+  parameters {
+    base64File(name: 'THEFILE')
+  }
+  stages {
+    stage('Example') {
+      steps {
+        withFileParameter(name:'THEFILE', allowNoFile: true) {
+          echo(/loaded '${readFile(FILE)}' from $FILE/)
+        }
+      }
+    }
+  }
+}
+  </pre>
+</div>

src/main/resources/io/jenkins/plugins/file_parameters/StashedFileParameterDefinition/help.html

@@ -4,7 +4,7 @@
 pipeline {
   agent any
   parameters {
-    stashedBase64File(name: 'FILE-STASH')
+    stashedFile(name: 'FILE-STASH')
   }
   stages {
     stage('Example') {

src/test/java/io/jenkins/plugins/file_parameters/FileParameterWrapperTest.java

@@ -62,15 +62,14 @@ public class FileParameterWrapperTest {
         r.assertLogContains("loaded 'UPLOADED CONTENT HERE' from ", b);
     }
 
-    @Ignore("need to implement option to tolerate undefined parameter")
-    @Test public void base64Undefined() throws Exception {
+    @Test public void base64UndefinedFail() throws Exception {
         r.createSlave("remote", null, null);
         WorkflowJob p = r.createProject(WorkflowJob.class, "myjob");
         p.addProperty(new ParametersDefinitionProperty(new Base64FileParameterDefinition("FILE", null)));
         String pipeline = "pipeline {\n" +
             "  agent any\n" +
             "  parameters {\n" +
-            "    base64File 'FILE'\n" +
+            "    base64File (name:'FILE')\n" +
             "  }\n" +
             "  stages {\n" +
             "    stage('Example') {\n" +
@@ -85,10 +84,35 @@ public class FileParameterWrapperTest {
         p.setDefinition(new CpsFlowDefinition(pipeline, true));
         WorkflowRun run = p.scheduleBuild2(0).get();
         r.waitForCompletion(run);
-        // definitely will fail but we just ensure parameter has been created
+        r.assertBuildStatus(Result.FAILURE, run);
+        r.assertLogContains("No parameter named FILE", run);
+    }
+
+    @Test public void base64WithAllowNoFile() throws Exception {
+        r.createSlave("remote", null, null);
+        WorkflowJob p = r.createProject(WorkflowJob.class, "myjob");
+        p.addProperty(new ParametersDefinitionProperty(new Base64FileParameterDefinition("FILE", null)));
+        String pipeline = "pipeline {\n" +
+            "  agent any\n" +
+            "  parameters {\n" +
+            "    base64File (name:'FILE')\n" +
+            "  }\n" +
+            "  stages {\n" +
+            "    stage('Example') {\n" +
+            "      steps {\n" +
+            "        withFileParameter(name:'FILE', allowNoFile: true) {\n" +
+            "          echo('foo') \n" +
+            "        }\n" +
+            "      }\n" +
+            "    }\n" +
+            "  }\n" +
+            "}";
+        p.setDefinition(new CpsFlowDefinition(pipeline, true));
+        WorkflowRun run = p.scheduleBuild2(0).get();
+        r.waitForCompletion(run);
         r.assertBuildStatus(Result.SUCCESS, run);
-        WorkflowRun b = p.getBuildByNumber(1);
-        r.assertLogContains("foo", b);
+        r.assertLogContains("foo", run);
+        r.assertLogContains("Skip file parameter as there is no parameter with name: 'FILE'", run);
     }
 
     @Test public void base64DeclarativeParameterCreated() throws Exception {
@@ -98,7 +122,7 @@ public class FileParameterWrapperTest {
         String pipeline = "pipeline {\n" +
             "  agent any\n" +
             "  parameters {\n" +
-            "    base64File 'FILE'\n" +
+            "    base64File (name: 'FILE')\n" +
             "  }\n" +
             "  stages {\n" +
             "    stage('Example') {\n" +
@@ -155,7 +179,7 @@ public class FileParameterWrapperTest {
         String pipeline = "pipeline {\n" +
             "    agent any\n" +
             "    parameters {\n" +
-            "        stashedBase64File 'FILE-STASH'\n" +
+            "        stashedFile (name:'FILE-STASH')\n" +
             "    }\n" +
             "    stages {\n" +
             "        stage('Example') {\n" +